[core][state] Task backend - Profile events capping - #33321
Merged
Merged
Conversation
rickyyx
marked this pull request as ready for review
March 15, 2023 06:36
rkooo567
reviewed
Mar 15, 2023
rkooo567
left a comment
rkooo567
left a comment
Contributor
There was a problem hiding this comment.
I have 2 questions!
- Is it common to have a task event with 100+ profile events? It seems extremely unlikely already
- When profile events > threshold, why do we drop the task event itself?
Member
Author
|
Release test:
|
rkooo567
approved these changes
Mar 16, 2023
Member
Author
|
Added comments. |
rickyyx
added
the
tests-ok
Member
Author
|
@rkooo567 - this shoudl be ready to merge. |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
This PR restricts the number of profile events to be sent and aggregates task events from the same task attempt on the worker side to reduce the data sent to GCS. This PR also refactos the metrics tracking to reduce lock contention on the core worker. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
clarng
pushed a commit
to clarng/ray
that referenced
this pull request
Mar 23, 2023
This PR restricts the number of profile events to be sent and aggregates task events from the same task attempt on the worker side to reduce the data sent to GCS. This PR also refactos the metrics tracking to reduce lock contention on the core worker.
chaowanggg
pushed a commit
to chaowanggg/ray-dev
that referenced
this pull request
Apr 4, 2023
This PR restricts the number of profile events to be sent and aggregates task events from the same task attempt on the worker side to reduce the data sent to GCS. This PR also refactos the metrics tracking to reduce lock contention on the core worker. Signed-off-by: chaowang <chaowang@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
This PR restricts the number of profile events to be sent and aggregates task events from the same task attempt on the worker side to reduce the data sent to GCS. This PR also refactos the metrics tracking to reduce lock contention on the core worker. Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
This PR restricts the number of profile events to be sent and aggregates task events from the same task attempt on the worker side to reduce the data sent to GCS. This PR also refactos the metrics tracking to reduce lock contention on the core worker. Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Release tests:
https://buildkite.com/ray-project/release-tests-pr/builds/30968#0186e373-19ec-4335-a4af-b82d5e9e0e42
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.