[serve] Add multi app support to serve run - #33347
Merged
Merged
Conversation
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Contributor
Author
sihanwang41
reviewed
Mar 20, 2023
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
edoakes
approved these changes
Mar 20, 2023
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Contributor
Author
|
@edoakes should be ready for merge |
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
* add multi app support to serve run Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * improve Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * lint Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * remove multiple import paths Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * address comments Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * improve serve run config Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * fixes Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * extend serve run port tests Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> --------- Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
* add multi app support to serve run Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * improve Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * lint Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * remove multiple import paths Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * address comments Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * improve serve run config Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * fixes Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> * extend serve run port tests Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> --------- Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add support for
serve runto run multiple applications at once.To run multiple applications with a config file:
CANNOT run multiple applications with import path arguments:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.