Skip to content

[Core][deps] pin json-schema < 4.18 - #33412

Merged
scv119 merged 2 commits into
ray-project:masterfrom
scv119:json-schema
Mar 17, 2023
Merged

[Core][deps] pin json-schema < 4.18#33412
scv119 merged 2 commits into
ray-project:masterfrom
scv119:json-schema

Conversation

@scv119

@scv119 scv119 commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Why are these changes needed?

#33411 there is a risk ray client_server will crash with jsonschema >= 4.18

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119
scv119 marked this pull request as ready for review March 17, 2023 04:19
@matthewdeng

matthewdeng commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Exclude from the prerelease test as well?

for dependency in attrs jsonschema aiosignal frozenlist requests protobuf
do
python -m pip install -U --pre --upgrade-strategy=eager $dependency
done

@scv119 scv119 changed the title [Core] pin json-schema < 4.18 [Core][deps] pin json-schema < 4.18 Mar 17, 2023
@clarng
clarng self-requested a review March 17, 2023 17:29

@cadedaniel cadedaniel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all test failures appear unrelated

@scv119
scv119 merged commit a9a92fd into ray-project:master Mar 17, 2023
scv119 added a commit to scv119/ray that referenced this pull request Mar 17, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18
@zcin zcin mentioned this pull request Mar 20, 2023
7 tasks
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18

Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
chaowanggg pushed a commit to chaowanggg/ray-dev that referenced this pull request Apr 4, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18


Signed-off-by: chaowang <chaowang@anyscale.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18

Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
ray-project#33411 there is a risk ray client_server will crash with jsonschema >= 4.18

Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants