Skip to content

[Metrics] Improve the existing OOM metrics - #33453

Merged
rkooo567 merged 4 commits into
ray-project:masterfrom
rkooo567:oom-count-metrics
Mar 25, 2023
Merged

[Metrics] Improve the existing OOM metrics#33453
rkooo567 merged 4 commits into
ray-project:masterfrom
rkooo567:oom-count-metrics

Conversation

@rkooo567

@rkooo567 rkooo567 commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

Why are these changes needed?

This PR improves the existing metrics to have the task/class information.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: SangBin Cho <rkooo567@gmail.com>
@rkooo567
rkooo567 requested a review from a team as a code owner March 20, 2023 07:59
@rkooo567

Copy link
Copy Markdown
Contributor Author

Still testing...

@rickyyx rickyyx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a screenshot or something? Or is the PR title not correct?

@rkooo567 rkooo567 changed the title [WIP][Metrics] Add the default OOM count dashboard [WIP][Metrics] Improve the existing OOM metrics Mar 25, 2023
@rkooo567 rkooo567 changed the title [WIP][Metrics] Improve the existing OOM metrics [Metrics] Improve the existing OOM metrics Mar 25, 2023

@rickyyx rickyyx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real stamp this time...

@rkooo567
rkooo567 merged commit 4e64ef3 into ray-project:master Mar 25, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
This PR improves the existing metrics to have the task/class information.

Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
This PR improves the existing metrics to have the task/class information.

Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants