[Datasets] Fix zip stage to preserve order when executing the other side - #33649
Merged
Conversation
Signed-off-by: Cheng Su <scnju13@gmail.com>
c21
requested review from
clarkzinzow,
ericl,
jianoaix,
jjyao and
scv119
as code owners
March 23, 2023 22:21
jianoaix
approved these changes
Mar 23, 2023
| executor: Executor, | ||
| plan: ExecutionPlan, | ||
| allow_clear_input_blocks: bool, | ||
| preserve_order: bool = False, |
Contributor
There was a problem hiding this comment.
Shall we make it required as other params and as upper call funcs?
Contributor
Author
There was a problem hiding this comment.
yeah we can make it required. sorry what do you mean by "as upper call funcs"?
Contributor
There was a problem hiding this comment.
Oh, the callers of this function, like execute_to_legacy_block_list.
Signed-off-by: Cheng Su <scnju13@gmail.com>
ericl
added
the
@author-action-required
c21
added
tests-ok
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ide (ray-project#33649) Found bug that `ZipStage` not preserve order when executing the right side. Though previously we have check if plan has zip or sort stage, that only enforces order from left side, but not enforces order from right side. See the added unit test for a reproduce example. User encounter the issue when enabling streaming execution on their workload. Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ide (ray-project#33649) Found bug that `ZipStage` not preserve order when executing the right side. Though previously we have check if plan has zip or sort stage, that only enforces order from left side, but not enforces order from right side. See the added unit test for a reproduce example. User encounter the issue when enabling streaming execution on their workload. Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Found bug that
ZipStagenot preserve order when executing the right side. Though previously we have check if plan has zip or sort stage, that only enforces order from left side, but not enforces order from right side.See the added unit test for a reproduce example. User encounter the issue when enabling streaming execution on their workload.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.