[tune] [no_early_kickoff] Fix OrderedDict import. - #33709
Merged
Conversation
krfricke
approved these changes
Mar 25, 2023
Contributor
|
Haha I created a separate PR with the same thing here: #33705... let me know which one you want to merge. |
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
8 tasks
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
matthewdeng
approved these changes
Mar 25, 2023
xwjiang2010
changed the title
OrderedDict import from py3.6.OrderedDict import.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
* fix `OrderedDict` in `experimental/output.py` Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * revert the try except catch in tune/tuner Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> --------- Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
* fix `OrderedDict` in `experimental/output.py` Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * revert the try except catch in tune/tuner Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> --------- Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove
OrderedDictimport.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.