Skip to content

[Data] Optimize metadata creation for RangeDatasource - #33712

Merged
ericl merged 2 commits into
ray-project:masterfrom
amogkam:fix-range-schema
Mar 25, 2023
Merged

[Data] Optimize metadata creation for RangeDatasource#33712
ericl merged 2 commits into
ray-project:masterfrom
amogkam:fix-range-schema

Conversation

@amogkam

@amogkam amogkam commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

The metadata calculation for range datasources only needs to be calculated once, and not per read task. This avoids long hangings during read task creation if the metadata creations takes a long time.

Closes #33695

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Comment thread python/ray/data/tests/test_dataset_tensor.py
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 25, 2023
@ericl ericl self-assigned this Mar 25, 2023
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@ericl
ericl merged commit 474b935 into ray-project:master Mar 25, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…33712)

Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[data] range_tensor() very slow to return with high parallelism and shape

2 participants