[RLlib] AlgorithmConfig.update_from_dict needs to work for MultiCallbacks. - #33796
Merged
Conversation
Signed-off-by: Jun Gong <jungong@anyscale.com>
gjoliver
requested review from
ArturNiederfahrenhorst,
avnishn,
kouroshHakha,
krfricke,
maxpumperla and
smorad
as code owners
March 28, 2023 06:46
Signed-off-by: Jun Gong <jungong@anyscale.com>
sven1977
reviewed
Mar 28, 2023
| value = deserialize_type(value, error=True) | ||
| # For backward compatibility reasons, only resolve possible | ||
| # classpath if value is a str type. | ||
| if isinstance(value, str): |
Contributor
There was a problem hiding this comment.
Should we just do error=False here instead of the if block?
This way, if value is already a class, nothing will happen.
sven1977
changed the title
AlgorithmConfig.update_from_dict needs to work for MultiCallbacks.
sven1977
approved these changes
Mar 28, 2023
sven1977
left a comment
sven1977
left a comment
Contributor
There was a problem hiding this comment.
LGTM now. Thanks for the fix @gjoliver . We should generally discuss, whether - instead of the current __call__-hack for MultiCallbacks, we should force users to write a light sub-class wrapper around MultiCallbacks with baked-in sub-callbacks (instead of handing the sub-callbacks as classes to the constructor).
zhe-thoughts
self-requested a review
March 28, 2023 15:39
zhe-thoughts
approved these changes
Mar 28, 2023
zhe-thoughts
left a comment
zhe-thoughts
left a comment
Contributor
There was a problem hiding this comment.
Approved for merging into master (we are under feature freeze now but this is critical fix)
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…lbacks. (ray-project#33796) Signed-off-by: Jun Gong <jungong@anyscale.com> Signed-off-by: sven1977 <svenmika1977@gmail.com> Co-authored-by: sven1977 <svenmika1977@gmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…lbacks. (ray-project#33796) Signed-off-by: Jun Gong <jungong@anyscale.com> Signed-off-by: sven1977 <svenmika1977@gmail.com> Co-authored-by: sven1977 <svenmika1977@gmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This breaks existing users who use MultiCallbacks instances.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.