[serve] Add telemetry for lightweight config updates - #34039
Merged
Conversation
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
zcin
marked this pull request as ready for review
April 4, 2023 14:20
zcin
requested review from
clarng,
edoakes,
shrekris-anyscale,
sihanwang41 and
zhe-thoughts
April 4, 2023 14:21
edoakes
approved these changes
Apr 4, 2023
edoakes
left a comment
edoakes
left a comment
Collaborator
There was a problem hiding this comment.
Just a nit, otherwise LGTM, do we need approval from anyone else on this?
Comment on lines
+63
to
+68
| // Whether num_replicas changed as a lightweight config update | ||
| SERVE_NUM_REPLICAS_UPDATED = 15; | ||
| // Whether user_config changed as a lightweight config update | ||
| SERVE_USER_CONFIG_UPDATED = 16; | ||
| // Whether autoscaling_config changed as a lightweight config update | ||
| SERVE_AUTOSCALING_CONFIG_UPDATED = 17; |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Whether num_replicas changed as a lightweight config update | |
| SERVE_NUM_REPLICAS_UPDATED = 15; | |
| // Whether user_config changed as a lightweight config update | |
| SERVE_USER_CONFIG_UPDATED = 16; | |
| // Whether autoscaling_config changed as a lightweight config update | |
| SERVE_AUTOSCALING_CONFIG_UPDATED = 17; | |
| // Whether num_replicas changed as a lightweight config update | |
| SERVE_NUM_REPLICAS_LIGHTWEIGHT_UPDATED = 15; | |
| // Whether user_config changed as a lightweight config update | |
| SERVE_USER_CONFIG_LIGHTWEIGHT_UPDATED = 16; | |
| // Whether autoscaling_config changed as a lightweight config update | |
| SERVE_AUTOSCALING_CONFIG_LIGHTWEIGHT_UPDATED = 17; |
Contributor
Author
There was a problem hiding this comment.
I believe we need approval from either @pcmoritz or @thomasdesr.
8 tasks
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
sihanwang41
approved these changes
Apr 4, 2023
Contributor
Author
|
Failures unrelated. @edoakes ready for merge |
zhe-thoughts
approved these changes
Apr 4, 2023
zhe-thoughts
left a comment
zhe-thoughts
left a comment
Contributor
There was a problem hiding this comment.
Approved for cherry picking
8 tasks
zcin
added a commit
to zcin/ray
that referenced
this pull request
Apr 5, 2023
This change adds new telemetry to get more insight into if and how users are using the lightweight config updates feature of Serve. It adds the telemetry tags: - `SERVE_NUM_REPLICAS_UPDATED`: whether `num_replicas` was updated (without any heavyweight option updated) - `SERVE_USER_CONFIG_UPDATED`: whether `user_config` was updated (without any heavyweight option updated) - `SERVE_AUTOSCALING_CONFIG_UPDATED`: whether `autoscaling_config` was updated (without any heavyweight option updated) These values are set to True as long as the user uses the feature at least once for any deployment in any application on the cluster. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
clarng
pushed a commit
that referenced
this pull request
Apr 5, 2023
This change adds new telemetry to get more insight into if and how users are using the lightweight config updates feature of Serve. It adds the telemetry tags: - `SERVE_NUM_REPLICAS_UPDATED`: whether `num_replicas` was updated (without any heavyweight option updated) - `SERVE_USER_CONFIG_UPDATED`: whether `user_config` was updated (without any heavyweight option updated) - `SERVE_AUTOSCALING_CONFIG_UPDATED`: whether `autoscaling_config` was updated (without any heavyweight option updated) These values are set to True as long as the user uses the feature at least once for any deployment in any application on the cluster. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
This change adds new telemetry to get more insight into if and how users are using the lightweight config updates feature of Serve. It adds the telemetry tags: - `SERVE_NUM_REPLICAS_UPDATED`: whether `num_replicas` was updated (without any heavyweight option updated) - `SERVE_USER_CONFIG_UPDATED`: whether `user_config` was updated (without any heavyweight option updated) - `SERVE_AUTOSCALING_CONFIG_UPDATED`: whether `autoscaling_config` was updated (without any heavyweight option updated) These values are set to True as long as the user uses the feature at least once for any deployment in any application on the cluster. Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
This change adds new telemetry to get more insight into if and how users are using the lightweight config updates feature of Serve. It adds the telemetry tags: - `SERVE_NUM_REPLICAS_UPDATED`: whether `num_replicas` was updated (without any heavyweight option updated) - `SERVE_USER_CONFIG_UPDATED`: whether `user_config` was updated (without any heavyweight option updated) - `SERVE_AUTOSCALING_CONFIG_UPDATED`: whether `autoscaling_config` was updated (without any heavyweight option updated) These values are set to True as long as the user uses the feature at least once for any deployment in any application on the cluster. Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change adds new telemetry to get more insight into if and how users are using the lightweight config updates feature of Serve. It adds the telemetry tags:
SERVE_NUM_REPLICAS_UPDATED: whethernum_replicaswas updated (without any heavyweight option updated)SERVE_USER_CONFIG_UPDATED: whetheruser_configwas updated (without any heavyweight option updated)SERVE_AUTOSCALING_CONFIG_UPDATED: whetherautoscaling_configwas updated (without any heavyweight option updated)These values are set to True as long as the user uses the feature at least once for any deployment in any application on the cluster.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.