Skip to content

Fix tensorarray to numpy conversion - #34115

Merged
jianoaix merged 9 commits into
ray-project:masterfrom
jianoaix:pandasversion
Apr 6, 2023
Merged

Fix tensorarray to numpy conversion#34115
jianoaix merged 9 commits into
ray-project:masterfrom
jianoaix:pandasversion

Conversation

@jianoaix

@jianoaix jianoaix commented Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why are these changes needed?

Fix CI failure in #34106

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jianoaix

jianoaix commented Apr 6, 2023

Copy link
Copy Markdown
Contributor Author

Although the Windows build/test failed, but the test test_unpack_dataframe (the goal of this PR) is fixed:

::TestBatchingFunctionFunctions::test_unpack_dataframe[batched_df0-expected0] PASSED
::TestBatchingFunctionFunctions::test_unpack_dataframe[batched_df1-expected1] PASSED

@jianoaix
jianoaix merged commit bb24c16 into ray-project:master Apr 6, 2023
@jianoaix jianoaix mentioned this pull request Apr 6, 2023
Merged
8 tasks
jianoaix added a commit to jianoaix/ray that referenced this pull request Apr 6, 2023
@jianoaix
Fix tensorarray to numpy conversion (ray-project#34115)
0838993 
* Revert "[Datasets] Revert "Enable streaming executor by default (ray-project#32493)" (ray-project#33485)"

This reverts commit 5c79954.

* Fix tensorarray to numpy conversion
jianoaix added a commit to jianoaix/ray that referenced this pull request Apr 6, 2023
@jianoaix
Fix tensorarray to numpy conversion (ray-project#34115)
1887fcf 
* Revert "[Datasets] Revert "Enable streaming executor by default (ray-project#32493)" (ray-project#33485)"

This reverts commit 5c79954.

* Fix tensorarray to numpy conversion
jianoaix added a commit that referenced this pull request Apr 6, 2023
@jianoaix
Fix tensorarray to numpy conversion (#34115) (#34142)
f74e3c9 
* Revert "[Datasets] Revert "Enable streaming executor by default (#32493)" (#33485)"

This reverts commit 5c79954.

* Fix tensorarray to numpy conversion
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@jianoaix @elliottower
Fix tensorarray to numpy conversion (ray-project#34115)
982a4c0 
* Revert "[Datasets] Revert "Enable streaming executor by default (ray-project#32493)" (ray-project#33485)"

This reverts commit 5c79954.

* Fix tensorarray to numpy conversion

Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@jianoaix @ProjectsByJackHe
Fix tensorarray to numpy conversion (ray-project#34115)
bcc6353 
* Revert "[Datasets] Revert "Enable streaming executor by default (ray-project#32493)" (ray-project#33485)"

This reverts commit 5c79954.

* Fix tensorarray to numpy conversion

Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sihanwang41 sihanwang41 sihanwang41 approved these changes

Assignees

@jiaodong jiaodong

@sihanwang41 sihanwang41

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jianoaix @sihanwang41 @jiaodong