Skip to content

missed cases in parse.usesCommonJs #980

Open

Description

@3cp

Two missed cases.

  1. npm package @aspnet/signalr file /dist/cjs/ILogger.js
"use strict";
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
Object.defineProperty(exports, "__esModule", { value: true });
var LogLevel;
(function (LogLevel) {
    LogLevel[LogLevel["Trace"] = 0] = "Trace";
    LogLevel[LogLevel["Information"] = 1] = "Information";
    LogLevel[LogLevel["Warning"] = 2] = "Warning";
    LogLevel[LogLevel["Error"] = 3] = "Error";
    LogLevel[LogLevel["None"] = 4] = "None";
})(LogLevel = exports.LogLevel || (exports.LogLevel = {}));
//# sourceMappingURL=ILogger.js.map

The existing parser missed (LogLevel = exports.LogLevel || (exports.LogLevel = {})) the assignment expression in right.

This can be fixed by modifying this line:

exp = node.expression || node.init;

To:

exp = node.expression || node.init || node;
  1. npm package @aspnet/signalr file /dist/cjs/IHubProtocol.js, this is essentially an empty file. Don't know how to reasonably identify this is commonjs file.
"use strict";
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
Object.defineProperty(exports, "__esModule", { value: true });
//# sourceMappingURL=IHubProtocol.js.map

Activity

  1. changed the title [-]missing catch in usesCommonJs[/-] [+]missing catch in parse.usesCommonJs[/+] on Apr 7, 2018
  2. changed the title [-]missing catch in parse.usesCommonJs[/-] [+]missed cases in parse.usesCommonJs[/+] on Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions