[beeckrumi0000]

Fixes #757.

resume -refresh builds a combinedGenerator, which never received flags.MemberOnly, so combinedChannels emitted every channel returned by the API. With a bot token, the first public channel the bot is not in failed with not_in_channel and stopped the resume.

This passes MemberOnly to combinedGenerator and makes combinedChannels skip public non-member channels with structures.IsMember, the same check chanFilter uses on the non-refresh path. Channels already in the list are still emitted as before.

Test: a new Test_combinedGenerator_Generate case lists one public member, one public non-member and two non-public channels with memberOnly set, and expects the non-member public channel to be skipped. go test ./... passes.

[rusq]

Thank you!

[beeckrumi0000]

Thanks for the review and the merge — and for maintaining slackdump.

We run it in production (bot token, -member-only, incremental resume), and this bug is exactly why our archive script carries a workaround: it resumes without -refresh and we add newly invited channels by id by hand. With #758 in, we would like to drop that and let resume discover channels again.

Would you consider cutting a release that includes it? No expectations on timing — your usual cadence is fine. We would just rather stay on official release artifacts than build from a commit. Thanks again!

[rusq]

Understood, will cook one now. Thank you for sharing your use case! I'm always interested to learn these kind of facts :)