Repository navigation
Fix cleanup tool to delete chunk payload. - #763
Merged
Merged
Conversation
rusq
added
the
ai-assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main problem was that foreign keys were not enabled on the connection (by
bootstrap.Database), so the CASCADE never worked. It did not affect other
modes, as they mainly insert the data, and never delete, so CASCADE wasn't
being used and it was never noticed.
The tests did not catch it because they have their own database opener.
Introduced a centralised dsn in the repository (in future, might move it to the
"database driver" package, because it's specific to SQLite, and if Postgress
will going to be added, it will have a different DSN builder).
Fixes #755 .