Skip to content

Android prop_info has changed sizeΒ #2844

Closed

Description

@joshtriplett

libc defines prop_info for Android, as an opaque type but one whose size presumably matters (since libc fills in fields to match its size). However, Android appears to have changed the size of the private fields: name is now a 0-length array at the end.

This structure doesn't seem to ever be handled by value, only by pointer, so I don't think we need to specify its private fields at all.

Activity

  1. Amanieu commented on Jul 12, 2022

    @Amanieu
    Member

    The stability policy for libc is not as strict as the standard library since it is intended to mirror an upstream API: if the upstream API changes then it we should mirror that change in libc. I don't think there is any sane way to manage API evolution otherwise.

  2. joshtriplett commented on Jul 12, 2022

    @joshtriplett
    MemberAuthor

    In this context, though, I think we don't need the structure to have a size.

  3. added a commit that references this issue on Jul 23, 2022
    2370f70
  4. added a commit that references this issue on Jul 31, 2022
    62a09a9
  5. added this to the 1.0 milestone on Aug 29, 2024
  6. added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    E-help-wantedCall for participation: Help is requested to fix this issue.
    and removed on Jun 24, 2026
  7. modified the milestones: 1.0, 1.x on Jun 24, 2026
  8. tgross35 commented on Jun 24, 2026

    @tgross35
    Member

    I thought this was breaking but it's not, so somebody can just put up a PR whenever updating the struct definition to match sources.

    If extern types were better supported then we would probably use them way more, but I don't think it's worth that change for the single case here.

  9. added a commit that references this issue on Oct 7, 2026
    a98d937
  10. added a commit that references this issue on Oct 10, 2026
    4560f67
  11. added a commit that references this issue on Oct 16, 2026
    a111b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: bugE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-help-wantedCall for participation: Help is requested to fix this issue.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions