Remove experimental --env-set option - #161831
Open
Urgau wants to merge 1 commit into
Open
Conversation
Collaborator
|
cc @rust-lang/rust-analyzer |
rustbot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Aug 26, 2026
nnethercote
reviewed
Aug 30, 2026
Because it's enabled by -Zunstable-options. :) |
nnethercote
approved these changes
Aug 30, 2026
Contributor
There was a problem hiding this comment.
If it's good enough for @GuillaumeGomez it's good enough for me.
| So if you first passed: | ||
|
|
||
| ```bash | ||
| --env-set A=B --env X=12 |
Contributor
There was a problem hiding this comment.
This --env was out of date.
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 31, 2026
Remove experimental `--env-set` option This PR removes the experimental/unstable `--env-set` option. The primary motivation for the feature meson/ninja [consider it](rust-lang#161609 (comment)) insufficient and a failure. They are even [planning](rust-lang#161609 (comment)) to use a wrapper anyway, entirely removing the need for it. I looked at GitHub search and apart from Buck2 who [seemed to be using it](rust-lang#161609 (comment)), I didn't find a significant user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the experimental/unstable
--env-setoption.The primary motivation for the feature meson/ninja consider it insufficient and a failure. They are even planning to use a wrapper anyway, entirely removing the need for it.
I looked at GitHub search and apart from Buck2 who seemed to be using it, I didn't find a significant user.
Close-ish #118372
cc @GuillaumeGomez @bonzini
r? @nnethercote