Repository navigation
update x509-limbo to latest - #508
Merged
Merged
Conversation
This brings in several new test cases: * Some new pathological chain building tests sourced from the Go test suite. We pass these as-expected. * A test for CVE-2025-61727, testing a name constraint issue from Go related to excluded subdomain constraints for wildcard leaf SANs. We pass this test as-expected. * Additional PSL wildcard SAN tests. We don't reject these when the test expects we should. This is because they require taking a dependency on the public suffix data, which is both large & frequently changing. We add these tests to our exceptions.json Additionally, upstream fixed a typo in two webpki::rsa test cases that we already had exceptions.json entries for. We update these to match the new name.
cpu
enabled auto-merge
June 9, 2026 15:09
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 20 20
Lines 3995 3995
=======================================
Hits 3902 3902
Misses 93 93 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
djc
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in several new test cases:
Additionally, upstream fixed a typo in two
webpki::rsatest cases (C2SP/x509-limbo#627) that we already had exceptions.json entries for. We update these to match the new name.