Skip to content

Require end entities to have digitalSignatures key usage - #511

Merged
djc merged 1 commit into
mainfrom
ee-digital-signature
Jun 11, 2026
Merged

djc merged 1 commit into
mainfrom
ee-digital-signature

Conversation

@djc

@djc djc commented Jun 11, 2026 •

Copy link
Copy Markdown
Member

Fixes #453.

(With help from Claude.)

@djc
djc requested review from cpu and ctz June 11, 2026 08:02
@djc
djc force-pushed the ee-digital-signature branch from 48b865e to 407b290 Compare June 11, 2026 08:03
@codecov

codecov Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.65%. Comparing base (a0bf408) to head (1e59ebb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   97.67%   97.65%   -0.02%     
==========================================
  Files          20       20              
  Lines        4045     4057      +12     
==========================================
+ Hits         3951     3962      +11     
- Misses         94       95       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/end_entity.rs Resolved
@djc
djc force-pushed the ee-digital-signature branch from 407b290 to 1e59ebb Compare June 11, 2026 11:34
@djc
djc requested a review from ctz June 11, 2026 11:34
@djc
djc added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit f2b2b01 Jun 11, 2026
25 checks passed
@djc
djc deleted the ee-digital-signature branch June 11, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check digitalSignature id-ce-keyUsage (if any) during EndEntityCert::verify_signature()

2 participants