Repository navigation
[dateparser] Add feature add_prefer_month_year - #1146
Merged
Merged
Conversation
- Add tests for this feature - #1042
Gallaecio
self-requested a review
March 27, 2023 12:44
adnan-awan
force-pushed
the
add-PREFER_MONTH_OF_YEAR-1042
branch
from
April 28, 2023 09:41
b31c4c4 to
03710f8
Compare
Gallaecio
reviewed
May 2, 2023
Contributor
There was a problem hiding this comment.
On the testing side, I think it would be good to cover an additional case where the current month has fewer days than the requested month. For example: Input: 2023, Current: April 15th, Preferred: last day, last month, Expected: Dec 31st (i.e. we are making sure it does not cause Dec 30th).
- For example: Input: 2023, Current: April 15th, Preferred: last day, last month, Expected: Dec 31st (i.e. we are making sure it does not cause Dec 30th). - #1042
Contributor
Author
|
Thanks @Gallaecio for useful suggestion! I've added the suggested test. Would you please review it again? |
serhii73
approved these changes
May 16, 2023
jimbofreedman
pushed a commit
to jimbofreedman/dateparser
that referenced
this pull request
Jul 4, 2023
|
@Gallaecio Just checking on when are you planning to push a new release which includes above changes? |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1042
To do: