Skip to content

Replace datetime.utcnow - #1179

Merged
Gallaecio merged 2 commits into
scrapinghub:masterfrom
cdce8p:replace-utcnow
Aug 21, 2023
Merged

Gallaecio merged 2 commits into
scrapinghub:masterfrom
cdce8p:replace-utcnow

Conversation

@cdce8p

@cdce8p cdce8p commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

Starting with Python 3.12 datetime.utcnow will be deprecated.
https://docs.python.org/3.12/library/datetime.html#datetime.datetime.utcnow

@Gallaecio

Copy link
Copy Markdown
Contributor

Could you run pre-commit on your changes?

pre-commit run --all

@Gallaecio
Gallaecio merged commit 725ccc0 into scrapinghub:master Aug 21, 2023
@Gallaecio

Copy link
Copy Markdown
Contributor

Thanks!

@cdce8p
cdce8p deleted the replace-utcnow branch August 21, 2023 14:56
@wimglenn

wimglenn commented Oct 4, 2023

Copy link
Copy Markdown

@Gallaecio Can you get this change released on PyPI, please?

@zerocewl

zerocewl commented Oct 6, 2023

Copy link
Copy Markdown

+1 a new release would be nice to work with python3.12

@Gallaecio

Copy link
Copy Markdown
Contributor

1.2.0 is out now πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants