Repository navigation
Parse some abbreviated strings as relative dates - #1219
Merged
Merged
Conversation
dateparser so far did consider strings like "1h20m" as an absolute time. This commit changes that, so "1h20" remains an absolute time, while "1h20m" is now considered a relative date. This makes the output much more predictable and not dependent on the use of whitespaces anymore. Fixes scrapinghub#1012 Behavior before the changes: ```python >>> from datetime import datetime >>> import dateparser >>> ref_date = datetime(2023, 1, 2, 3, 4, 5) >>> dateparser.parse("1h20", settings={"RELATIVE_BASE": ref_date}) datetime.datetime(2023, 1, 2, 1, 20) >>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date}) datetime.datetime(2023, 1, 2, 1, 20) >>> dateparser.parse("1h 20m", settings={"RELATIVE_BASE": ref_date}) datetime.datetime(2023, 1, 2, 1, 44, 5) >>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date, "PREFER_DATES_FROM": "future"}) datetime.datetime(2023, 1, 3, 1, 20) ``` Behavior after the changes: ```python >>> from datetime import datetime >>> import dateparser >>> ref_date = datetime(2023, 1, 2, 3, 4, 5) >>> dateparser.parse("1h20", settings={"RELATIVE_BASE": ref_date}) datetime.datetime(2023, 1, 2, 1, 20) >>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date}) datetime.datetime(2023, 1, 2, 1, 44, 5) >>> dateparser.parse("1h 20m", settings={"RELATIVE_BASE": ref_date}) datetime.datetime(2023, 1, 2, 1, 44, 5) >>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date, "PREFER_DATES_FROM": "future"}) datetime.datetime(2023, 1, 2, 4, 24, 5) ```
Gallaecio
approved these changes
Feb 16, 2024
Contributor
|
Thanks! |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dateparser so far did consider strings like "1h20m" as an absolute time. This commit changes that, so "1h20" remains an absolute time, while "1h20m" is now considered a relative date. This makes the output much more predictable and not dependent on the use of whitespaces anymore.
Fixes #1012
Behavior before the changes:
Behavior after the changes: