Skip to content

Upgrade ruff - #1406

Merged
AdrianAtZyte merged 5 commits into
scrapinghub:masterfrom
AdrianAtZyte:ruff-fstrings
Sep 30, 2026
Merged

AdrianAtZyte merged 5 commits into
scrapinghub:masterfrom
AdrianAtZyte:ruff-fstrings

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Member

No description provided.

@codspeed

codspeed Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 7 untouched benchmarks


Comparing AdrianAtZyte:ruff-fstrings (66e4a8e) with master (2d06c1c)

Open in CodSpeed

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 98.54%. Comparing base (2d06c1c) to head (66e4a8e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
+ Coverage   98.22%   98.54%   +0.31%     
==========================================
  Files         237      237              
  Lines        3158     3087      -71     
==========================================
- Hits         3102     3042      -60     
+ Misses         56       45      -11     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 23, 2026 08:49

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Heads-up for the rebase: dateparser/date.py conflicts with #1474 (trivial: keep the RE_SANITIZE_DASH line). After the rebase, the new ruff config also flags code that #1431 added to master: for token, type in tokens: in _parser._has_month_name (A001, builtin shadowing). It isn't auto-fixable, so pre-commit will be red until that variable is renamed.

@AdrianAtZyte
AdrianAtZyte merged commit ed396fc into scrapinghub:master Sep 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants