Skip to content

Stop reading "Nth day" as a number of days in English dates - #1412

Merged
AdrianAtZyte merged 1 commit into
scrapinghub:masterfrom
AdrianAtZyte:ordinal-day
Sep 30, 2026
Merged

AdrianAtZyte merged 1 commit into
scrapinghub:masterfrom
AdrianAtZyte:ordinal-day

Conversation

@AdrianAtZyte

@AdrianAtZyte AdrianAtZyte commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Fixes #1256, closes #1383. Part of #1265.

@codspeed

codspeed Bot commented Sep 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 7 untouched benchmarks


Comparing AdrianAtZyte:ordinal-day (f40b728) with master (901414a)

Open in CodSpeed

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 97.21%. Comparing base (901414a) to head (f40b728).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1412   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         236      236           
  Lines        3084     3084           
=======================================
  Hits         2998     2998           
  Misses         86       86           

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 23, 2026 09:36

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianAtZyte
AdrianAtZyte merged commit 0f6b389 into scrapinghub:master Sep 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to parse "the 1st day of March"

2 participants