Skip to content

Take the current date from the configured time zone - #1427

Merged
AdrianAtZyte merged 6 commits into
scrapinghub:masterfrom
AdrianAtZyte:current-date-timezone
Sep 30, 2026
Merged

AdrianAtZyte merged 6 commits into
scrapinghub:masterfrom
AdrianAtZyte:current-date-timezone

Conversation

@AdrianAtZyte

@AdrianAtZyte AdrianAtZyte commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Fixes #772, Fixes #934, fixes #1196

@codspeed

codspeed Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 7 untouched benchmarks


Comparing AdrianAtZyte:current-date-timezone (89a4e5c) with master (e64dd08)

Open in CodSpeed

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 98.87%. Comparing base (e64dd08) to head (89a4e5c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1427       +/-   ##
===========================================
+ Coverage    0.00%   98.87%   +98.87%     
===========================================
  Files         238      238               
  Lines        3336     3384       +48     
===========================================
+ Hits            0     3346     +3346     
+ Misses       3336       38     -3298     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 23, 2026 13:42

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Heads-up for the rebase: dateparser/parser.py conflicts with #1431. When resolving it, pass tz=tz to both cls(...) calls in _parser.parse, including the swapped-order retry (cls(tokens, settings, date_order=swapped, tz=tz)). Otherwise a swapped reading takes "now" from TIMEZONE instead of the string's own zone.

@AdrianAtZyte
AdrianAtZyte merged commit c8d6a17 into scrapinghub:master Sep 30, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants