Skip to content

Add type hints - #1457

Merged
AdrianAtZyte merged 4 commits into
scrapinghub:masterfrom
AdrianAtZyte:mypy
Sep 30, 2026
Merged

AdrianAtZyte merged 4 commits into
scrapinghub:masterfrom
AdrianAtZyte:mypy

Conversation

@AdrianAtZyte

@AdrianAtZyte AdrianAtZyte commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Resolves #961

@codspeed

codspeed Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 7 untouched benchmarks


Comparing AdrianAtZyte:mypy (90c1cf0) with master (ed396fc)

Open in CodSpeed

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 98.81%. Comparing base (ed396fc) to head (90c1cf0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   98.54%   98.81%   +0.27%     
==========================================
  Files         237      237              
  Lines        3087     3204     +117     
==========================================
+ Hits         3042     3166     +124     
+ Misses         45       38       -7     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 27, 2026 13:03

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Heads-up for the rebase: dateparser/parser.py conflicts with #1431 (keep master's _parser.parse body under the typed signature). mypy on the rebased tree then reports 8 errors, all in code master added since this PR's base: the untyped _has_month_name called from typed parse, plus a few new tests in tests/test_timezone_parser.py, tests/test_date_parser.py and tests/test_date.py. The new mypy CI leg will be red until they are annotated.

@AdrianAtZyte
AdrianAtZyte merged commit e3a3888 into scrapinghub:master Sep 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are you interested in adding type hints?

2 participants