Repository navigation
Add type hints - #1457
Merged
Merged
Add type hints#1457
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
+ Coverage 98.54% 98.81% +0.27%
==========================================
Files 237 237
Lines 3087 3204 +117
==========================================
+ Hits 3042 3166 +124
+ Misses 45 38 -7 β View full report in Codecov by Harness. π New features to boost your workflow:
|
AdrianAtZyte
marked this pull request as ready for review
September 27, 2026 13:03
serhii73
approved these changes
Sep 30, 2026
serhii73
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Heads-up for the rebase: dateparser/parser.py conflicts with #1431 (keep master's _parser.parse body under the typed signature). mypy on the rebased tree then reports 8 errors, all in code master added since this PR's base: the untyped _has_month_name called from typed parse, plus a few new tests in tests/test_timezone_parser.py, tests/test_date_parser.py and tests/test_date.py. The new mypy CI leg will be red until they are annotated.
This was referenced Oct 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #961