Skip to content

Parse ISO 8601 fractional seconds written with a decimal comma - #1467

Merged
AdrianAtZyte merged 2 commits into
scrapinghub:masterfrom
AdrianAtZyte:iso-comma-fraction
Sep 30, 2026
Merged

AdrianAtZyte merged 2 commits into
scrapinghub:masterfrom
AdrianAtZyte:iso-comma-fraction

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Member

Part of #914.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 98.86%. Comparing base (36d0af5) to head (aa61299).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
+ Coverage   92.53%   98.86%   +6.32%     
==========================================
  Files         238      238              
  Lines        3255     3257       +2     
==========================================
+ Hits         3012     3220     +208     
+ Misses        243       37     -206     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 7 untouched benchmarks


Comparing AdrianAtZyte:iso-comma-fraction (aa61299) with master (36d0af5)

Open in CodSpeed

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 28, 2026 11:46

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianAtZyte
AdrianAtZyte merged commit 6bd27c4 into scrapinghub:master Sep 30, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants