Skip to content

Stop dropping extra numbers when parsing dates - #1480

Merged
AdrianAtZyte merged 4 commits into
scrapinghub:masterfrom
AdrianAtZyte:search-extra-number
Sep 30, 2026
Merged

AdrianAtZyte merged 4 commits into
scrapinghub:masterfrom
AdrianAtZyte:search-extra-number

Conversation

@AdrianAtZyte

@AdrianAtZyte AdrianAtZyte commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Fixes #856, fixes #1264, closes #1402

@codspeed

codspeed Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 7 untouched benchmarks


Comparing AdrianAtZyte:search-extra-number (80f1640) with master (e3a3888)

Open in CodSpeed

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 98.81%. Comparing base (e3a3888) to head (80f1640).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         237      237           
  Lines        3204     3218   +14     
=======================================
+ Hits         3166     3180   +14     
  Misses         38       38           

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 29, 2026 12:00

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianAtZyte
AdrianAtZyte merged commit a82a8c2 into scrapinghub:master Sep 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interpreting time Parse whole words only

2 participants