Skip to content

Add a Minguo calendar for Taiwanese dates - #1489

Merged
AdrianAtZyte merged 2 commits into
scrapinghub:masterfrom
AdrianAtZyte:minguo-calendar
Sep 30, 2026
Merged

AdrianAtZyte merged 2 commits into
scrapinghub:masterfrom
AdrianAtZyte:minguo-calendar

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Member

Resolves #837

@codspeed

codspeed Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 7 untouched benchmarks


Comparing AdrianAtZyte:minguo-calendar (2f5097b) with master (0961388)

Open in CodSpeed

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 98.86%. Comparing base (a3fafe5) to head (2f5097b).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   98.81%   98.86%   +0.04%     
==========================================
  Files         237      238       +1     
  Lines        3218     3251      +33     
==========================================
+ Hits         3180     3214      +34     
+ Misses         38       37       -1     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 29, 2026 22:13

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianAtZyte AdrianAtZyte reopened this Sep 30, 2026
@AdrianAtZyte
AdrianAtZyte merged commit 778db63 into scrapinghub:master Sep 30, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse Taiwan dates

2 participants