Skip to content

Deprecate instead of remove - #1556

Merged
AdrianAtZyte merged 5 commits into
scrapinghub:masterfrom
AdrianAtZyte:deprecate-instead-of-remove
Oct 30, 2026
Merged

AdrianAtZyte merged 5 commits into
scrapinghub:masterfrom
AdrianAtZyte:deprecate-instead-of-remove

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Member

No description provided.

@AdrianAtZyte AdrianAtZyte mentioned this pull request Oct 29, 2026
2 tasks done
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 99.19%. Comparing base (533b0df) to head (599afae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   99.18%   99.19%   +0.01%     
==========================================
  Files         239      239              
  Lines        4030     4098      +68     
==========================================
+ Hits         3997     4065      +68     
  Misses         33       33              

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

βœ… 10 untouched benchmarks


Comparing AdrianAtZyte:deprecate-instead-of-remove (599afae) with master (533b0df)

Open in CodSpeed

@serhii73 serhii73 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CI is green, and I ran the full suite with this PR and the other pending 1.5.0 changes together (25107 passed).

Two non-blocking gaps compared with 1.4.3, both on undocumented extension points, that you may want to close here or in a follow-up. I checked both against v1.4.3:

  • CalendarBase.get_date() now calls parser._parse_with_parts(). A parser class that only has parse(source, settings) -> (date, period) raises AttributeError; it works on 1.4.3.
  • DateParser.parse() still unpacks the result of parse_method as (date, period, parts). A parse_method that returns (date, period) raises ValueError: not enough values to unpack; it works on 1.4.3.

Neither affects the library's own code paths.

@AdrianAtZyte
AdrianAtZyte merged commit b1a87f9 into scrapinghub:master Oct 30, 2026
19 checks passed
serhii73 added a commit to AdrianAtZyte/dateparser that referenced this pull request Nov 4, 2026
Bring the draft in line with master after "Deprecate instead of remove"
(scrapinghub#1556): what it turned back into deprecations moves from "Breaking changes"
to "Deprecations", and the removal of the public parse() return tuples is
dropped because it no longer happens.

Check every other entry against the code and 1.4.3: replace examples that
behave the same on 1.4.3 or only under explicit languages with ones that
show the change, add the caveats a user would trip over (the ngram strategy
of the date_formats argument, the locales of the Levantine month names, the
default PREFER_MONTH_OF_YEAR for quarters), drop the English label-and-colon
example of scrapinghub#1496 because scrapinghub#1482 undid that change, and add the fixes that had
no entry: the region argument (scrapinghub#1423), Russian numeric dates (scrapinghub#1554) and the
IndexError of search_dates() for zh-Hans, zh-Hant and yue (scrapinghub#1401, scrapinghub#1407).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
serhii73 added a commit that referenced this pull request Nov 4, 2026
* Add release notes for 1.5.0

* Update the 1.5.0 release notes

Bring the draft in line with master after "Deprecate instead of remove"
(#1556): what it turned back into deprecations moves from "Breaking changes"
to "Deprecations", and the removal of the public parse() return tuples is
dropped because it no longer happens.

Check every other entry against the code and 1.4.3: replace examples that
behave the same on 1.4.3 or only under explicit languages with ones that
show the change, add the caveats a user would trip over (the ngram strategy
of the date_formats argument, the locales of the Levantine month names, the
default PREFER_MONTH_OF_YEAR for quarters), drop the English label-and-colon
example of #1496 because #1482 undid that change, and add the fixes that had
no entry: the region argument (#1423), Russian numeric dates (#1554) and the
IndexError of search_dates() for zh-Hans, zh-Hant and yue (#1401, #1407).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Serhii A <24910277+serhii73@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants