Skip to content

GOB: add kFeaturesTrueColor to ADI4 variants - #7860

Merged
bluegr merged 4 commits into
scummvm:masterfrom
BJNFNE:adi4-tc
Aug 21, 2026
Merged

bluegr merged 4 commits into
scummvm:masterfrom
BJNFNE:adi4-tc

Conversation

@BJNFNE

@BJNFNE BJNFNE commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Now everything is correct and all my german variants have kFeaturesTrueColor

Followup from #7859

Sorry for the trouble :)

Bildschirmfoto vom 2026-08-21 14-27-49

The intro gets now loaded properly and titlescreen / adi room is now usable for german version 4.01

The issue was in 00001449: o7_loadImage("A_PARCHE.TGA", 99, 0, 0, 640, 34, 0, 34, 0); (LIBAPPELL.TOT)

Without kFeaturesTrueColor it crash after creating the user while entering adis room on loading A_PARCHE.TGA due to unknown dithering error message

@bluegr

bluegr commented Aug 21, 2026

Copy link
Copy Markdown
Member

How about the rest of the ADI4 variants? Do they also use a truecolor resolution?

@BJNFNE

BJNFNE commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

I only have my german adi4 versions, i do not have the english versions, in 4.21 i know they changed it so they no longer use TrueColor there.

@BJNFNE

BJNFNE commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

But it behaves now identical to 4.21 variants

so those long graphical bugs are now fixed for 4.01.

@BJNFNE

BJNFNE commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@bluegr Wait, i check my french version i let you know just a sec

@BJNFNE

BJNFNE commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

now it should be complete :) and ready to review

@bluegr

bluegr commented Aug 21, 2026

Copy link
Copy Markdown
Member

OK. How about the rest of the ADI4 variants in that file?

@BJNFNE

BJNFNE commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@bluegr I dont think i have them in my collection :(

For now i think we can merge this if you are fine with that. :)

@BJNFNE

BJNFNE commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Although i can check the demos

@BJNFNE BJNFNE changed the title GOB: add kFeaturesTrueColor to ADI4 german variants GOB: add kFeaturesTrueColor to ADI4 variants Aug 21, 2026
@bluegr

bluegr commented Aug 21, 2026

Copy link
Copy Markdown
Member

Thanks! Squashing

@bluegr
bluegr merged commit 1471cd3 into scummvm:master Aug 21, 2026
1 check passed
@BJNFNE
BJNFNE deleted the adi4-tc branch August 21, 2026 15:22
@sdelamarre

Copy link
Copy Markdown
Contributor

@BJNFNE thanks! Normally there is an opcode, o7_initScreen, which is responsible for selecting the color mode (truecolor or not). You can check if it is called in your German version before the crash. If not, it means that we need to rely on marking those versions as using truecolor mode by default, like you did. However if the opcode is called, then maybe we must fix something in its implementation.

Can you also check what happens when you open an application like "Math"? As far as I remember those are paletted, so there should be an o7_initDisk call at some point to change color mode from paletted to true color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants