Repository navigation
GOB: add kFeaturesTrueColor to ADI4 variants - #7860
Conversation
|
How about the rest of the ADI4 variants? Do they also use a truecolor resolution? |
|
I only have my german adi4 versions, i do not have the english versions, in 4.21 i know they changed it so they no longer use TrueColor there. |
|
But it behaves now identical to 4.21 variants so those long graphical bugs are now fixed for 4.01. |
|
@bluegr Wait, i check my french version i let you know just a sec |
|
now it should be complete :) and ready to review |
|
OK. How about the rest of the ADI4 variants in that file? |
|
@bluegr I dont think i have them in my collection :( For now i think we can merge this if you are fine with that. :) |
|
Although i can check the demos |
The demo play fine since kFeaturesTrueColor is added
|
Thanks! Squashing |
|
@BJNFNE thanks! Normally there is an opcode, o7_initScreen, which is responsible for selecting the color mode (truecolor or not). You can check if it is called in your German version before the crash. If not, it means that we need to rely on marking those versions as using truecolor mode by default, like you did. However if the opcode is called, then maybe we must fix something in its implementation. Can you also check what happens when you open an application like "Math"? As far as I remember those are paletted, so there should be an o7_initDisk call at some point to change color mode from paletted to true color. |
Now everything is correct and all my german variants have kFeaturesTrueColor
Followup from #7859
Sorry for the trouble :)
The intro gets now loaded properly and titlescreen / adi room is now usable for german version 4.01
The issue was in 00001449: o7_loadImage("A_PARCHE.TGA", 99, 0, 0, 640, 34, 0, 34, 0); (LIBAPPELL.TOT)
Without kFeaturesTrueColor it crash after creating the user while entering adis room on loading A_PARCHE.TGA due to unknown dithering error message