Skip to content

improve mouse-button names - #1168

Merged
sezanzeb merged 6 commits into
sezanzeb:mainfrom
Pxtl:mouse_button_names
Oct 25, 2025
Merged

sezanzeb merged 6 commits into
sezanzeb:mainfrom
Pxtl:mouse_button_names

Conversation

@Pxtl

@Pxtl Pxtl commented Sep 26, 2025 •

Copy link
Copy Markdown
Contributor
  • The SIDE, EXTRA, FORWARD, BACK, and TASK buttons are now just called "Button 4" and 5, 6, 7 and 8
    • changed because evdev names are confusing and misleading
      (eg button SIDE is actually button BACK on most extra-button mice).
  • Mouse buttons 9 and 10 are now supported (tested this on my mouse)
    • TODO: Probably could go higher if someone has access to a mouse that can emit higher buttons for testing,
      there's space in the event-space for up to Button 16 (0x11F)
  • also stop logging warnings on empty mappings

stop logging warnings on empty mappings
instead of guessing that everything up to 0x18F is legit mouse button
@Pxtl

Pxtl commented Sep 27, 2025

Copy link
Copy Markdown
Contributor Author

@sezanzeb do you need clean history? I can squash if needed. Sorry for needing so many pipeline builds. I just really tripped over the confusing names when setting up my mouse, since evdev calls the wrong buttons BACK and FORWARD, and treated some other buttons as UNKNOWN.

@sezanzeb

Copy link
Copy Markdown
Owner

Hi, thanks! I forgot about your pull request, sorry.

Could you please extend the existing test_beautify test? (I hope I'm not mistaken and that this is the one that will cover your changes)

@sezanzeb

Copy link
Copy Markdown
Owner

I usually squash all pull requests via the button in github, no worries

@Pxtl

Pxtl commented Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

@sezanzeb updated test_beautify

@sezanzeb
sezanzeb merged commit 9224bbb into sezanzeb:main Oct 25, 2025
@sezanzeb

Copy link
Copy Markdown
Owner

Thank you!

@Pxtl
Pxtl deleted the mouse_button_names branch October 27, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants