Repository navigation
improve mouse-button names - #1168
Merged
Merged
Conversation
stop logging warnings on empty mappings
instead of guessing that everything up to 0x18F is legit mouse button
Contributor
Author
|
@sezanzeb do you need clean history? I can squash if needed. Sorry for needing so many pipeline builds. I just really tripped over the confusing names when setting up my mouse, since evdev calls the wrong buttons BACK and FORWARD, and treated some other buttons as UNKNOWN. |
Owner
|
Hi, thanks! I forgot about your pull request, sorry. Could you please extend the existing |
Owner
|
I usually squash all pull requests via the button in github, no worries |
Contributor
Author
|
@sezanzeb updated |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(eg button SIDE is actually button BACK on most extra-button mice).
there's space in the event-space for up to Button 16 (0x11F)