Skip to content

Support default services for trusted-root and signing-config creation - #4592

Merged
Hayden-IO merged 1 commit into
sigstore:mainfrom
Hayden-IO:default-services
Jan 5, 2026
Merged

Hayden-IO merged 1 commit into
sigstore:mainfrom
Hayden-IO:default-services

Conversation

@Hayden-IO

@Hayden-IO Hayden-IO commented Dec 19, 2025 •

Copy link
Copy Markdown
Contributor

When a client doesn't want to use a default service like Rekor while still using the public instance, a client would need to retrieve the signing configuration or trusted root, remove the tlog sections, and provide that to the sign/verify command. This first step can now be skipped by using --with-default-services and --no-<service> to omit it from the configuration file. This will provide a better user experience while maintaining the unified configuration interface between clients.

Ref: docker/actions-toolkit#901

Summary

Release Note

Documentation

@codecov

codecov Bot commented Dec 19, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.94118% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.05%. Comparing base (2ef6022) to head (0035278).
⚠️ Report is 627 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/trustedroot.go 0.00% 22 Missing ⚠️
cmd/cosign/cli/signingconfig/signingconfig.go 28.00% 15 Missing and 3 partials ⚠️
cmd/cosign/cli/signingconfig.go 0.00% 12 Missing ⚠️
cmd/cosign/cli/trustedroot/trustedroot.go 25.00% 11 Missing and 1 partial ⚠️
cmd/cosign/cli/options/signingconfig.go 0.00% 5 Missing ⚠️
cmd/cosign/cli/options/trustedroot.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4592      +/-   ##
==========================================
- Coverage   40.10%   36.05%   -4.05%     
==========================================
  Files         155      220      +65     
  Lines       10044    12413    +2369     
==========================================
+ Hits         4028     4476     +448     
- Misses       5530     7241    +1711     
- Partials      486      696     +210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hayden-IO
Hayden-IO force-pushed the default-services branch 4 times, most recently from 65a7104 to c4d942b Compare December 22, 2025 04:54
When a client doesn't want to use a default service like Rekor while
still using the public instance, a client would need to retrieve the
signing configuration or trusted root, remove the tlog sections, and
provide that to the sign/verify command. This first step can now be
skipped by using --with-default-services and --no-<service> to omit it
from the configuration file. This will provide a better user experience
while maintaining the unified configuration interface between clients.

Ref: docker/actions-toolkit#901

Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
@Hayden-IO

Copy link
Copy Markdown
Contributor Author

Verified working with cosign trusted-root create --with-default-services and cosign signing-config create --with-default-services --no-default-rekor.

@Hayden-IO
Hayden-IO marked this pull request as ready for review December 22, 2025 05:30
@Hayden-IO
Hayden-IO requested a review from a team as a code owner December 22, 2025 05:30

@steiza steiza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hayden-IO
Hayden-IO merged commit 246945e into sigstore:main Jan 5, 2026
29 checks passed
@Hayden-IO
Hayden-IO deleted the default-services branch January 5, 2026 16:55
fghanmi pushed a commit to securesign/cosign that referenced this pull request Jan 22, 2026
…sigstore#4592)

When a client doesn't want to use a default service like Rekor while
still using the public instance, a client would need to retrieve the
signing configuration or trusted root, remove the tlog sections, and
provide that to the sign/verify command. This first step can now be
skipped by using --with-default-services and --no-<service> to omit it
from the configuration file. This will provide a better user experience
while maintaining the unified configuration interface between clients.

Ref: docker/actions-toolkit#901

Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants