Skip to content

Remove unused signing code - #4918

Merged
steiza merged 16 commits into
sigstore:mainfrom
aaronlew02:delete-code
Jun 12, 2026
Merged

steiza merged 16 commits into
sigstore:mainfrom
aaronlew02:delete-code

Conversation

@aaronlew02

@aaronlew02 aaronlew02 commented Jun 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This change removes signing code that remains unused as signing occurs exclusively via sigstore-go.

Tests are slightly refactored to eliminate reliance on unused signing code.

@codecov

codecov Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 37.71%. Comparing base (2ef6022) to head (b0f2c93).
⚠️ Report is 764 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4918      +/-   ##
==========================================
- Coverage   40.10%   37.71%   -2.39%     
==========================================
  Files         155      211      +56     
  Lines       10044    12743    +2699     
==========================================
+ Hits         4028     4806     +778     
- Misses       5530     7237    +1707     
- Partials      486      700     +214     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaronlew02
aaronlew02 force-pushed the delete-code branch 3 times, most recently from a3a7b09 to cee6d8f Compare June 5, 2026 21:48
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
@aaronlew02
aaronlew02 force-pushed the delete-code branch 3 times, most recently from a1b7ae8 to 7b43b16 Compare June 8, 2026 16:44
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
@aaronlew02
aaronlew02 marked this pull request as ready for review June 8, 2026 20:25
@aaronlew02
aaronlew02 requested review from a team as code owners June 8, 2026 20:25

@steiza steiza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! These giant reductions in code we have to maintain is exactly why we started this Cosign modernization effort ~2 years ago.

Unfortunately Go's dead code detection is pretty good, and so the resulting binary is pretty much the same size. πŸ˜… But regardless, having less code to maintain and surface area for LLM-assisted vulnerability discovery is definitely a win.

Comment thread pkg/cosign/verify_test.go Resolved
@steiza
steiza merged commit 0fc9811 into sigstore:main Jun 12, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants