Repository navigation
Remove unused signing code - #4918
Merged
Merged
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4918 +/- ##
==========================================
- Coverage 40.10% 37.71% -2.39%
==========================================
Files 155 211 +56
Lines 10044 12743 +2699
==========================================
+ Hits 4028 4806 +778
- Misses 5530 7237 +1707
- Partials 486 700 +214 β View full report in Codecov by Harness. π New features to boost your workflow:
|
aaronlew02
force-pushed
the
delete-code
branch
3 times, most recently
from
June 5, 2026 21:48
a3a7b09 to
cee6d8f
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
aaronlew02
force-pushed
the
delete-code
branch
3 times, most recently
from
June 8, 2026 16:44
a1b7ae8 to
7b43b16
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
steiza
approved these changes
Jun 9, 2026
steiza
left a comment
Member
There was a problem hiding this comment.
Amazing! These giant reductions in code we have to maintain is exactly why we started this Cosign modernization effort ~2 years ago.
Unfortunately Go's dead code detection is pretty good, and so the resulting binary is pretty much the same size. π But regardless, having less code to maintain and surface area for LLM-assisted vulnerability discovery is definitely a win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes signing code that remains unused as signing occurs exclusively via sigstore-go.
Tests are slightly refactored to eliminate reliance on unused signing code.