Repository navigation
fix: pass NewBundleFormat to KeyOpts in sign command - #4981
Merged
Hayden-IO merged 1 commit intoJul 4, 2026
Merged
Conversation
Signed-off-by: JasonPowr <japower@redhat.com>
JasonPowr
force-pushed
the
fix/sign-new-bundle-format-keyopts
branch
from
July 3, 2026 10:55
ae11e61 to
ceeaf83
Compare
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4981 +/- ##
==========================================
- Coverage 40.10% 38.48% -1.62%
==========================================
Files 155 209 +54
Lines 10044 13007 +2963
==========================================
+ Hits 4028 5006 +978
- Misses 5530 7291 +1761
- Partials 486 710 +224 β View full report in Codecov by Harness. π New features to boost your workflow:
|
This was referenced Jul 6, 2026
JasonPowr
added a commit
to securesign/cosign
that referenced
this pull request
Jul 7, 2026
fix: pass NewBundleFormat to KeyOpts in sign command (sigstore#4981)
JasonPowr
added a commit
to securesign/cosign
that referenced
this pull request
Jul 7, 2026
fix: pass NewBundleFormat to KeyOpts in sign command (sigstore#4981)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewBundleFormatis parsed from the CLI flag but never copied toKeyOptsinsign.go,causing TSA signing to fail with:
This only affects the manual flags path (
--use-signing-config=falsewith explicit--timestamp-server-url). The default signing config path is unaffected as it sourcesTSA and bundle format settings from the trusted root / signing config, bypassing
KeyOpts.Fix: add the missing
NewBundleFormat: o.NewBundleFormatto theKeyOptsstruct initialization.Fixes: #4980