Repository navigation
fix add more highlight - #2593
Merged
Merged
Conversation
Contributor
Author
|
fix #2618 |
sinelaw
approved these changes
Jul 12, 2026
sinelaw
left a comment
sinelaw
left a comment
Owner
There was a problem hiding this comment.
This is an autogenerated comment
- Reviewed against CONTRIBUTING.md: adds 9 syntect grammars (Metal, CUDA, HIP, Fortran, MLIR, LLVM IR, Gettext PO, M4, Xcode pbxproj) following the exact existing pattern in
config.rs/types.rs/build.rs— no duplication, no architectural changes. - Confirmed no prior support existed for any of these languages/extensions (grepped master) — fixes real gaps (#2556, #2557, #2560, #2612, #2618), not duplicate features.
- Includes unit tests (grammar load + path resolution) and e2e
test_highlighting_works!coverage per fixture, satisfying the "reproduce before claiming" rule. cargo check --all-targetspasses cleanly (62 embedded syntaxes, up from 53).- Manually validated interactively via tmux: opened
hello.cu,hello.f90,project.pbxproj,hello.m4,hello.pofixtures in a built binary — each is correctly detected in the status bar (CUDA/Fortran/Xcode Project/M4/Gettext PO) and renders distinct token coloring (keywords, strings, comments, punctuation). - Approving — simple, well-scoped, low-risk data addition.
Generated by Claude Code
Owner
|
👍 |
sinelaw
pushed a commit
that referenced
this pull request
Jul 15, 2026
Audited all 60 PRs merged after the v0.4.3 tag and added the user-facing ones the 0.4.4 section was missing: new/fixed syntax grammars (#2593, #2553), vi find-char operators (#2441), LSP range formatting (#2605), monorepo git support (#2369), large wrapped-file edit lag (#2610), dormant-SSH dock dives (#2570), per-split terminal scrollback (#2595), and tab-bar scroll-into-view (#2675). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QiCqqGW2WzTNrQPSKetF2W
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add syntax highlighting for more languages and file formats
Adds Sublime-syntax grammars (with test fixtures) for nine additional languages/formats and registers them in the grammar loader.
New grammars
.pohello.po.m4hello.m4.pbxprojproject.pbxproj.metalhello.metal.cuhello.cu.hiphello.hip.f90hello.f90.llhello.ll.mlirhello.mlirChanges
crates/fresh-editor/src/grammars/.build.rs,config.rs, andprimitives/grammar/types.rs.tests/fixtures/syntax_highlighting/and extendedtests/e2e/syntax_highlighting_coverage.rsto cover them.Closes
Fortran, LLVM IR, and MLIR grammars are included as additional coverage beyond the linked issues.