Repository navigation
Centralize event hook mechanism for plugins - #44
Merged
sinelaw merged 1 commit intoNov 6, 2025
Merged
Conversation
…concerns This commit fully implements the architecture described in docs/plugin_api_analysis.md section "Centralize event application" by ensuring ALL events go through a single method that automatically handles all cross-cutting concerns. Changes: - Enhanced apply_event_to_active_buffer() to automatically call notify_lsp_change() - Added comprehensive documentation explaining the centralized approach - Replaced all 20+ direct .apply() calls throughout the codebase with apply_event_to_active_buffer() - Removed duplicate notify_lsp_change() calls (now handled automatically) Benefits: - Hooks ALWAYS fire - impossible to forget - LSP notifications ALWAYS sent - impossible to forget - Single place to add new cross-cutting concerns (logging, analytics, etc.) - Eliminates "pit of failure" where devs must remember to call hooks manually - Easier to maintain and extend This follows the proper event architecture: Event generated → Event applied → Hooks triggered → LSP notified
sinelaw
deleted the
claude/centralize-event-hooks-011CUsDVQm4ybAG1A2mVFsG8
branch
November 6, 2025 20:05
sinelaw
pushed a commit
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…concerns
This commit fully implements the architecture described in docs/plugin_api_analysis.md section "Centralize event application" by ensuring ALL events go through a single method that automatically handles all cross-cutting concerns.
Changes:
Benefits:
This follows the proper event architecture:
Event generated → Event applied → Hooks triggered → LSP notified