Repository navigation
configuration: small fixes - #837
Merged
archisman-panigrahi merged 2 commits intoApr 13, 2026
Merged
Conversation
deltragon
force-pushed
the
configuration-misc-fixes
branch
3 times, most recently
from
January 20, 2026 10:19
996f4dc to
39f2557
Compare
This was referenced Jan 20, 2026
Contributor
|
I'm looking forward to this. :) |
Also skip saving the file on load if it is unchanged. (It will only changed when new default values are added on an update). The timing when the config is loaded is moved around, as otherwise logging may not be initialized yet.
Only load the config in the main GTK instance, and not the CLI instances. This can be changed again later, but it is not needed right now, so we skip it.
deltragon
force-pushed
the
configuration-misc-fixes
branch
from
April 12, 2026 19:35
39f2557 to
3303ac9
Compare
deltragon
marked this pull request as ready for review
April 12, 2026 19:36
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #836, only the last two commits are new.
Separated out of that PR to make the behaviour changes more visible.