You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm happy to merge these for new users.
However, I'm unsure if we want to add them automatically for existing users. Personally, my breaks are highly customized and specific - I've got a personal regimen from a physiotherapist - and new breaks added automatically would interfere with that (as my specific breaks happen less often, then).
I see our default breaks as suggestions, ideas for the users - but I expect that users who customized their breaks don't want any added automatically.
We could show a popup once, after updating, offering to add the breaks - that, imo, would hit the balance of not disturbing power users and notifying the users who want the default that there are new breaks.
(Alternatively, we could simply check if users customized the breaks at all, and only add the new ones if their breaks are the same as the old default ones.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some new short and long breaks.
This will not affect existing installations, though. I would be happy to know your feedback about how we can update the existing installations.