Skip to content

Add new long and short breaks - #861

Merged
deltragon merged 1 commit into
slgobinath:masterfrom
archisman-panigrahi:new-short-and-long-breaks
Apr 19, 2026
Merged

deltragon merged 1 commit into
slgobinath:masterfrom
archisman-panigrahi:new-short-and-long-breaks

Conversation

@archisman-panigrahi

Copy link
Copy Markdown
Collaborator

Added some new short and long breaks.

This will not affect existing installations, though. I would be happy to know your feedback about how we can update the existing installations.

@deltragon

Copy link
Copy Markdown
Collaborator

I'm happy to merge these for new users.
However, I'm unsure if we want to add them automatically for existing users. Personally, my breaks are highly customized and specific - I've got a personal regimen from a physiotherapist - and new breaks added automatically would interfere with that (as my specific breaks happen less often, then).
I see our default breaks as suggestions, ideas for the users - but I expect that users who customized their breaks don't want any added automatically.
We could show a popup once, after updating, offering to add the breaks - that, imo, would hit the balance of not disturbing power users and notifying the users who want the default that there are new breaks.
(Alternatively, we could simply check if users customized the breaks at all, and only add the new ones if their breaks are the same as the old default ones.)

@archisman-panigrahi

Copy link
Copy Markdown
Collaborator Author

Let's just merge as it is without notifying existing users

@deltragon
deltragon merged commit d00e876 into slgobinath:master Apr 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants