Repository navigation
feat(cct-sdk): Make sender optional on transfer + accept admin - #509
Conversation
|
π apedrob, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
CI Test Reportβ 4420/4420 tests passed (1099 suites) in 6m 54s SummaryCoverage report |
|
You must have Developer access to commit code to Chainlink Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
andrevmatos
left a comment
There was a problem hiding this comment.
LGTM, approving. The signed path is unchanged: the base execute still sets sender to the wallet through resolveWalletSender, so the role check runs there. Without sender, the unsigned path skips only the role check and builds a tx with no from, while the registration and pending checks still run, in the same order (so sender: ZeroAddress still cannot match an unregistered token). Typecheck, lint, and the CCT unit tests pass on 22597dc3.
What
senderoptional ongenerateUnsignedTransferAdminandgenerateUnsignedAcceptAdmin, likeregisterAdmin; omitting it skips only the admin checkWhy
Testing
Notes
sender, andexecutestill defaults it to the wallet