Repository navigation
fix(sdk): treat Solana 2.0 lanes in testing as 1.6 in every method - #537
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 andrevmatos, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
CI Test Report✅ 4583/4583 tests passed (1133 suites) in 6m 5s SummaryCoverage report |
andrevmatos
force-pushed
the
solana/auto
branch
from
November 10, 2026 12:17
bc3a1d5 to
3eb7c62
Compare
PabloMansanet
left a comment
PabloMansanet
left a comment
Collaborator
There was a problem hiding this comment.
What happens on a lane that's v2 only, with an allowlist? (i.e. staging, used in the fork tests). Could we fall back to 2.0 when there's no 1.6 config?
Other than that, LGTM!
A Solana 2.0 Router lane with its sender allowlist enabled is in testing. getFee and sendMessage already sent over its 1.6 lane; now the other methods agree: - getLaneFeatures reports no fast finality for it. - getOnRampConfig without opts.version reads the 1.6 lane config, and returns the lane read as laneVersion. - getRequiredCCVs and estimateReceiveExecution discover the 1.6 OffRamp. - CLI lane shows the 1.6 lane and OffRamp by default. A SolanaChain instance memoizes each lane's observe_dest_chain_v2 result for 10 min, so these methods see the same lane version. After the allowlist is lifted, they select 2.0 with no SDK update. The internal sendV2OnAllowlistedLanes opt-in stays for getFee and send.
andrevmatos
force-pushed
the
solana/auto
branch
from
November 10, 2026 12:38
3eb7c62 to
053a92e
Compare
bukata-sa
approved these changes
Nov 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Solana 2.0 Router lane with its sender allowlist enabled is in testing. getFee and sendMessage already sent over its 1.6 lane; now the other methods agree:
A SolanaChain instance memoizes each lane's observe_dest_chain_v2 result for 10 min, so these methods see the same lane version. After the allowlist is lifted, they select 2.0 with no SDK update. The internal sendV2OnAllowlistedLanes opt-in stays for getFee and send.