Repository navigation
Update arbitrum gas estimator's settings - #487
Conversation
|
There was a problem hiding this comment.
Pull request overview
Updates Arbitrum estimator tuning parameters to better handle fee volatility by increasing the suggested gas price buffer and reducing an internal refresh interval.
Changes:
- Reduce
arbitrumEstimatorpolling interval from 10s to 2s. - Increase Arbitrum gas price buffer from +50% to +75% (1.5x -> 1.75x).
- Update unit tests to reflect the new buffer behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/gas/arbitrum_estimator.go | Adjusts Arbitrum estimator polling period and increases the gas price buffer percentage. |
| pkg/gas/arbitrum_estimator_test.go | Updates expected values/constants to match the new buffer percentage. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dimriou
left a comment
There was a problem hiding this comment.
LGTM - It would be great if we can spin it up locally and test the behaviour just to be on the safe side.
@dimriou Done! Below is the output, which shows that the base fee gets refreshed every 2s and is computed correctly: |
c82708e
What
Update arbitrum gas estimator settings:
Why
Basically, there's no higher bound on arbitrum's block-over-block base fee increases, so to deal with that better we shorten the refresh interval and increase the bump percentage.