Skip to content

install tron & ton; relative install paths - #17867

Merged
jmank88 merged 2 commits into
developfrom
install-more-loops
Sep 16, 2025
Merged

install tron & ton; relative install paths#17867
jmank88 merged 2 commits into
developfrom
install-more-loops

Conversation

@jmank88

@jmank88 jmank88 commented May 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@jmank88
jmank88 requested a review from chainchad May 23, 2025 14:52
@jmank88 jmank88 mentioned this pull request May 23, 2025
Closed
jmank88
jmank88 commented May 23, 2025
View reviewed changes
Comment thread GNUmakefile Resolved
chainchad
chainchad reviewed May 23, 2025
View reviewed changes
Comment thread GNUmakefile Resolved
chainchad
chainchad reviewed May 27, 2025
View reviewed changes
Comment thread go.sum Resolved
@github-actions

github-actions Bot commented Jul 27, 2025

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open days with no activity.
Remove the stale label, comment, or update this PR to prevent this PR from being closed in days.

@github-actions github-actions Bot added the Stale label Jul 27, 2025
@jmank88 jmank88 removed the Stale label Jul 28, 2025
@jmank88
jmank88 force-pushed the install-more-loops branch 2 times, most recently from c49835c to 1e6421b Compare August 19, 2025 23:52
@jmank88
jmank88 requested a review from chainchad August 19, 2025 23:53
@jmank88
jmank88 force-pushed the install-more-loops branch 5 times, most recently from 8930c18 to 062c822 Compare August 20, 2025 23:30
@jmank88
jmank88 force-pushed the install-more-loops branch 7 times, most recently from 76b379f to e86b77d Compare September 8, 2025 13:56
This was referenced Sep 8, 2025
Merged
Merged
@jmank88
jmank88 requested a review from pavel-raykov September 8, 2025 13:59
@jmank88
jmank88 force-pushed the install-more-loops branch 2 times, most recently from da3817c to 8b7a232 Compare September 8, 2025 20:38
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

1 similar comment
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88
jmank88 marked this pull request as ready for review September 16, 2025 11:53
@jmank88
jmank88 requested review from a team as code owners September 16, 2025 11:53
pavel-raykov
pavel-raykov previously approved these changes Sep 16, 2025
View reviewed changes
@jmank88

jmank88 commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

I don't understand why some tests are still trying to run make install-loopinstall. Are they using the wrong commit?

@jmank88
jmank88 enabled auto-merge September 16, 2025 13:19
@cl-sonarqube-production

cl-sonarqube-production Bot commented Sep 16, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

jmank88
jmank88 commented Sep 16, 2025
View reviewed changes
Comment thread GNUmakefile

@jmank88 jmank88 Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored make install-loopinstall since it is used from outside this repo. We can circle back later.

jmank88
jmank88 commented Sep 16, 2025
View reviewed changes
Comment thread testdata/scripts/health/multi-chain-loopp.txtar
-- out.txt --
ok Aptos.42.RelayerService
ok Aptos.42.RelayerService.PluginRelayerClient
ok Aptos.42.RelayerService.PluginRelayerClient.PluginAptos

@jmank88 jmank88 Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like aptos is either not starting cleanly, or the health report is not wired through... 🤔

@jmank88
jmank88 added this pull request to the merge queue Sep 16, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 16, 2025
@jmank88
jmank88 added this pull request to the merge queue Sep 16, 2025
Merged via the queue into develop with commit 93740bd Sep 16, 2025
@jmank88
jmank88 deleted the install-more-loops branch September 16, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chainchad chainchad chainchad approved these changes
@george-dorin george-dorin george-dorin approved these changes
@pavel-raykov pavel-raykov pavel-raykov approved these changes
@skudasov skudasov Awaiting requested review from skudasov
@ettec ettec Awaiting requested review from ettec
@Tofel Tofel Awaiting requested review from Tofel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmank88 @chainchad @george-dorin @pavel-raykov