Repository navigation
[PRODCRE-792] Support capabilities that are both Triggers and Executables - #19102
Merged
Merged
Conversation
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
2 times, most recently
from
August 27, 2025 04:40
bb70143 to
aaa59f7
Compare
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
6 times, most recently
from
August 28, 2025 04:48
89c0710 to
ca7a685
Compare
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
3 times, most recently
from
September 4, 2025 03:01
cc59a85 to
b5609e0
Compare
bolekk
changed the title
|
|
||
| methodConfig := capabilityConfig.CapabilityMethodConfig | ||
| if methodConfig != nil { // v2 capability | ||
| w.exposeCapabilityV2(ctx, cid, methodConfig, myPeerID, don, idsToDONs) |
Contributor
There was a problem hiding this comment.
also, shouldn't you check capability.CapabilityType==nil to make sure people not use both types of parametrizations at the same time?
Contributor
Author
There was a problem hiding this comment.
This type doesn't matter here any more. exposeCapabilityV2() goes method-by-method
krehermann
reviewed
Sep 4, 2025
| return nil | ||
| } | ||
|
|
||
| func (w *launcher) exposeCapabilityV2(ctx context.Context, capID string, methodConfig map[string]capabilities.CapabilityMethodConfig, myPeerID p2ptypes.PeerID, myDON registrysyncer.DON, idsToDONs map[uint32]capabilities.DON) error { |
Contributor
There was a problem hiding this comment.
@george-dorin uncovered a very hairy bug (ticket pending...) where it seem like if the loop crashes the in-memory registry is corrupted and never recovers despite a new loop process starting.
how does this code get alerted/triggered by, say, a looop restart?
Contributor
Author
There was a problem hiding this comment.
It doesn't. And it didn't even before this change :( I opened a separate epic to handle dynamic updates to underlying capabilities and config, which should include LOOPP restarts (CRE-788)
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
7 times, most recently
from
September 8, 2025 05:03
30d2f55 to
a6bea65
Compare
bolekk
force-pushed
the
feature/PRODCRE-792-remote-shims-for-v2-caps
branch
from
September 8, 2025 05:33
a6bea65 to
7c7cebc
Compare
bolekk
marked this pull request as ready for review
September 8, 2025 05:36
|
cedric-cordenier
approved these changes
Sep 8, 2025
agparadiso
approved these changes
Sep 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 8, 2025
…bles (#19102) [DRAFT][PRODCRE-792] Support capabilities that are both Triggers and Executables
This was referenced Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launcher per-method shims and CombinedClient.
CombinedClient unit tests generated with Claude.