Repository navigation
(feat): Add ListPendingJobProposals and ApproveJobProposalByID to the GQL SDK Client - #21643
Conversation
|
👋 justinkaseman, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — adds new public SDK surface area and introduces derived behavior (cross-manager filtering + approval-by-proposal-id) that callers may rely on.
Adds convenience methods to the GQL SDK client for enumerating job proposals whose latest spec is pending and for approving a job proposal by proposal ID.
Changes:
- Add
PendingJobProposaltype to the SDK client types. - Extend the
Clientinterface + implementation withListPendingJobProposalsandApproveJobProposalByID. - Expand SDK README with structure/prerequisites/usage guidance; add a changeset entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
deployment/environment/web/sdk/client/types.go |
Introduces PendingJobProposal DTO for pending proposal listings. |
deployment/environment/web/sdk/client/client.go |
Adds two new client methods and updates the Client interface. |
deployment/environment/web/sdk/README.md |
Documents SDK structure, prerequisites, extension guidance, and usage pointers. |
.changeset/bright-pens-glow.md |
Declares a patch-level changeset for the SDK addition. |
|
No description provided.