Skip to content

Doc: Diagram: Fix typo in DatasetPackage; Fix arrow label positions in Licensing; Sort properties - #722

Merged
goneall merged 15 commits into
spdx:mainfrom
bact:sort-in-diagram
Apr 30, 2024
Merged

Doc: Diagram: Fix typo in DatasetPackage; Fix arrow label positions in Licensing; Sort properties#722
goneall merged 15 commits into
spdx:mainfrom
bact:sort-in-diagram

Conversation

@bact

@bact bact commented Apr 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Fix typo in DatasetPackage: datasetPreprocessing -> dataPreprocessing
  • Fix arrow label positions in Licensing (* and 2..* between AnyLicenseInfo, ConjuctiveLicenseSet, and DisjunctiveLicenseSet)
  • Sort in Diagram: properties/enums in AI, Dataset, Software Enumerations, and Licensing to match order in the spec https://spdx.github.io/spdx-spec/v3.0/
  • Sort in related Markdown files
  • Fix Markdown format warnings (markdownlint)

@bact bact changed the title Diagram: Fix typo in DatasetPackage; Fix arrow label positions in Licesing; Sort Diagram: Fix typo in DatasetPackage; Fix arrow label positions in Licensing; Sort properties Apr 21, 2024
@bact bact changed the title Diagram: Fix typo in DatasetPackage; Fix arrow label positions in Licensing; Sort properties Doc: Diagram: Fix typo in DatasetPackage; Fix arrow label positions in Licensing; Sort properties Apr 22, 2024
@bact

bact commented Apr 23, 2024

Copy link
Copy Markdown
Collaborator Author

@sbarnum please kindly review

@kestewart
kestewart requested review from goneall and swinslow April 23, 2024 22:25
@kestewart kestewart added this to the 3.0.1 milestone Apr 23, 2024
@kestewart
kestewart requested a review from sbarnum April 23, 2024 23:14
goneall
goneall approved these changes Apr 23, 2024
View reviewed changes

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bact added 2 commits April 30, 2024 13:00
@rnjudge

rnjudge commented Apr 30, 2024

Copy link
Copy Markdown
Collaborator

Looks good! LGTM

@goneall
goneall merged commit 1fb00f7 into spdx:main Apr 30, 2024
@bact
bact deleted the sort-in-diagram branch April 30, 2024 17:21
@zvr

zvr commented May 1, 2024

Copy link
Copy Markdown
Member

Argh! Splitting vocabularies to multiple lines stops the whole parsing. @bact

@zvr

zvr commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

It makes no sense to have PRs doing a number of unrelated changes...
Now I can't revert this PR to fix the vocabularies, since it also touches diagrams and other stuff.

@bact

bact commented May 2, 2024

Copy link
Copy Markdown
Collaborator Author

Thank you @zvr. Sorry for the break. I'm fixing this now.

bact added a commit to bact/spec-parser that referenced this pull request May 2, 2024
@bact
SingleListSection.load() to consume multiline
66193f5 
To fix error introduced by  spdx/spdx-3-model#722

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact mentioned this pull request May 2, 2024
Closed
@bact

bact commented May 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@zvr can you check this spdx/spec-parser#129 please ?

If this solution is ok, I will implement a similar thing for NestedListSection as well. Thank you.

@zvr

zvr commented May 2, 2024

Copy link
Copy Markdown
Member

Let's fix the input.

I can provide a PR in the weekend, if noone else does before then.

@bact bact added the typo Typos, minor spelling errors, or minor incorrect word usage label Nov 13, 2024
@bact bact added the diagram Diagrams for SPDX model and others label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goneall goneall goneall approved these changes
@swinslow swinslow Awaiting requested review from swinslow
@sbarnum sbarnum Awaiting requested review from sbarnum

Assignees

No one assigned

Labels

diagram Diagrams for SPDX model and others typo Typos, minor spelling errors, or minor incorrect word usage

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@bact @rnjudge @zvr @goneall @kestewart