Skip to content

Add .editorconfig and .gitattributes to enforce newline and whitespace consistency - #739

Merged
goneall merged 3 commits into
spdx:mainfrom
bact:add-editorconfig
Apr 30, 2024
Merged

goneall merged 3 commits into
spdx:mainfrom
bact:add-editorconfig

Conversation

@bact

@bact bact commented Apr 28, 2024 •

Copy link
Copy Markdown
Collaborator

bact added 2 commits April 28, 2024 22:14
Using configurations from
https://github.com/spdx/spdx-spec/blob/development/v3.0.1/.editorconfig

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Using configurations from
https://github.com/spdx/spdx-spec/blob/development/v3.0.1/.gitattributes

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@zvr

zvr commented Apr 30, 2024

Copy link
Copy Markdown
Member

Why shouldn't people in Windows have their native line endings?

Sorry, I may be misunderstanding something...

@bact

bact commented Apr 30, 2024

Copy link
Copy Markdown
Collaborator Author

We can make it auto (crlf for Windows, lf for the rest), just try keeping both spdx-spec and spdx-3-model repos using the same convention.

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kestewart kestewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good idea. Thank you!

@kestewart kestewart added this to the 3.0.1 milestone Apr 30, 2024
@goneall
goneall merged commit d1a673a into spdx:main Apr 30, 2024
@bact
bact deleted the add-editorconfig branch April 30, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants