Skip to content

Add spacing for better readability. - #757

Merged
kestewart merged 2 commits into
spdx:mainfrom
vargenau:add-spacing
May 1, 2024
Merged

kestewart merged 2 commits into
spdx:mainfrom
vargenau:add-spacing

Conversation

@vargenau

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>

@kestewart kestewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks better this way.

@kestewart kestewart added this to the 3.0.1 milestone Apr 30, 2024

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall

goneall commented Apr 30, 2024

Copy link
Copy Markdown
Member

@vargenau - if you could resolve the merge conflicts, I can merge this in

@bact

bact commented Apr 30, 2024 •

Copy link
Copy Markdown
Collaborator

Already fixed by #723

The issue with one long paragraph in https://spdx.github.io/spdx-spec/v3.0/model/Core/Classes/NamespaceMap/ comes from the fact that the ordered list:

  1. Use 1) 2) 3) instead of 1. 2. 3.
  2. Use 3 spaces for indent

This is already fixed in main. See NamespaceMap.md

Spacing issue in https://spdx.github.io/spdx-spec/v3.0/model/Core/Properties/dataLicense/ is also got fixed.
See dataLicense

@kestewart

Copy link
Copy Markdown
Contributor

Ok, I took a pass at fixing the conflicts. Hopefully it's ok. If not, we'll do a new PR. Merging this.

@kestewart
kestewart merged commit f167edb into spdx:main May 1, 2024
@bact

bact commented May 1, 2024 •

Copy link
Copy Markdown
Collaborator

Please see #760 for the fix for 1. vs 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants