Skip to content

Remove unnecessary restrictions - #797

Merged
goneall merged 2 commits into
spdx:mainfrom
zvr:unnecessary-restrictions
Jul 22, 2024
Merged

Remove unnecessary restrictions#797
goneall merged 2 commits into
spdx:mainfrom
zvr:unnecessary-restrictions

Conversation

@zvr

@zvr zvr commented Jul 10, 2024

Copy link
Copy Markdown
Member

Now that spec-parser processes and check external property restrictions, the following warnings were generated:

WARNING: In class /AI/AIPackage property /Core/Artifact/releaseTime has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Core/Artifact/suppliedBy has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Software/Package/downloadLocation has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Software/Package/packageVersion has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Software/SoftwareArtifact/primaryPurpose has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Core/Artifact/builtTime has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Core/Artifact/releaseTime has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Software/Package/downloadLocation has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Software/SoftwareArtifact/primaryPurpose has same maxCount as the parent class
WARNING: In class /Security/VulnAssessmentRelationship property /Core/Relationship/to has same minCount as the parent class

This PR removes these unnecessary external property restrictions.

@zvr
Deletes unnecessary external property restrictions
2f54f43 
Signed-off-by: Alexios Zavras (zvr) <github@zvr.gr>
@zvr zvr added this to the 3.0.1 milestone Jul 10, 2024
@kestewart

kestewart commented Jul 14, 2024

Copy link
Copy Markdown
Contributor

@rgopikrishnan91 - please review.

@kestewart kestewart added Profile:AI Artificial Intelligence profile and related matters Profile:Dataset Dataset profile and related matters labels Jul 14, 2024
@bact

bact commented Jul 16, 2024

Copy link
Copy Markdown
Collaborator

Discussed in 2024-07-16 Tech team meeting, agree to merge.

@zvr
Merge branch 'main' into unnecessary-restrictions
1afe317 
Signed-off-by: Alexios Zavras (zvr) <github@zvr.gr>
goneall
goneall approved these changes Jul 22, 2024
View reviewed changes

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - based on comments, was approved during tech call - merging

@goneall
goneall merged commit 2f8066e into spdx:main Jul 22, 2024
@zvr
zvr deleted the unnecessary-restrictions branch August 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goneall goneall goneall approved these changes

Assignees

No one assigned

Labels

Profile:AI Artificial Intelligence profile and related matters Profile:Dataset Dataset profile and related matters

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@zvr @kestewart @bact @goneall