Skip to content

Update cpe23 link in ExternalIdentifierType - #806

Merged
zvr merged 9 commits into
spdx:mainfrom
bact:update-urls-ExternalIdentifierType
Jul 30, 2024
Merged

zvr merged 9 commits into
spdx:mainfrom
bact:update-urls-ExternalIdentifierType

Conversation

@bact

@bact bact commented Jul 25, 2024 •

Copy link
Copy Markdown
Collaborator
  • Make cpe23 URL matched with one in the References chapter (see Update References chapter spdx-spec#1006 )
  • Add full names to some entries.
    • For example, swid here is specifically a concise SWID one according to the ref. So add "Concise Software Identification tag" to the description.
  • Update obsoleted ref
    • swid ref to a pre-RFC Internet Draft that expired on 8 Sep 2022, updated to RFC 9393 which replace it
  • Make all URLs clickable. Also add text labels to bare URLs, as required by OMG/ISO standard doc

bact added 3 commits July 25, 2024 11:45
Make URL matched with one in the References chapter

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
`swid` here is specifically a concise SWID one according to the ref

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>

@zvr zvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links should not be visible (I only did a couple)

Comment thread model/Core/Vocabularies/ExternalIdentifierType.md Outdated
Comment thread model/Core/Vocabularies/ExternalIdentifierType.md Outdated
bact and others added 2 commits July 26, 2024 11:28
Co-authored-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
bact requested a review from zvr July 26, 2024 10:39
@bact

bact commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator Author

Links should not be visible (I only did a couple)

Thanks. I have made all of them invisible now.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zvr
zvr merged commit ff3d857 into spdx:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants