Repository navigation
Merged
Conversation
For the purpose of OMG/ISO standard doc preparation. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
68 of 69 tasks
Collaborator
Author
goneall
requested changes
Jul 31, 2024
goneall
left a comment
Member
There was a problem hiding this comment.
One suggested change, otherwise looks good.
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
rnjudge
requested changes
Aug 6, 2024
Collaborator
Author
|
Thank you Rose, I will recheck all of them again for formatting. |
Collaborator
Author
|
Thank you Rose for detailed reviews concerning newlines, I have replied them all on why and with screenshots demonstrating how they will be rendered. |
kestewart
approved these changes
Aug 9, 2024
kestewart
left a comment
Contributor
There was a problem hiding this comment.
Rationale for line changes and evidence makes sense. Moving forward with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the purpose of OMG/ISO standard doc preparation.
This PR will fix #792 too.