Skip to content

[Security] Add text labels to bare URLs - #812

Merged
goneall merged 9 commits into
spdx:mainfrom
bact:fix-link-security-profile
Aug 9, 2024
Merged

goneall merged 9 commits into
spdx:mainfrom
bact:fix-link-security-profile

Conversation

@bact

@bact bact commented Jul 26, 2024 •

Copy link
Copy Markdown
Collaborator

For the purpose of OMG/ISO standard doc preparation.

This PR will fix #792 too.

For the purpose of OMG/ISO standard doc preparation.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact mentioned this pull request Jul 26, 2024
68 of 69 tasks
@bact

bact commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator Author

@zvr @goneall @rnjudge if you have some time, please kindly review. Thank you.

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change, otherwise looks good.

Comment thread model/Security/Properties/vectorString.md Outdated
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
bact requested a review from goneall July 31, 2024 21:56
bact added 3 commits July 31, 2024 23:10
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@kestewart
kestewart requested a review from rnjudge August 6, 2024 16:13

@rnjudge rnjudge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bact Some general formatting that should probably be fixed but content looks good.

Comment thread model/Security/Classes/SsvcVulnAssessmentRelationship.md
Comment thread model/Security/Properties/decisionType.md
Comment thread model/Security/Vocabularies/CvssSeverityType.md
Comment thread model/Security/Vocabularies/CvssSeverityType.md
Comment thread model/Security/Vocabularies/SsvcDecisionType.md
@bact

bact commented Aug 6, 2024

Copy link
Copy Markdown
Collaborator Author

Thank you Rose, I will recheck all of them again for formatting.

@bact

bact commented Aug 7, 2024

Copy link
Copy Markdown
Collaborator Author

Thank you Rose for detailed reviews concerning newlines, I have replied them all on why and with screenshots demonstrating how they will be rendered.

@bact
bact requested a review from rnjudge August 8, 2024 19:48

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New updates look good - Thanks @bact

@kestewart kestewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rationale for line changes and evidence makes sense. Moving forward with this.

@goneall
goneall merged commit 482472c into spdx:main Aug 9, 2024
@bact
bact deleted the fix-link-security-profile branch August 9, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

percentile definition is specific to EPSS

4 participants