Skip to content

Fix typos, casing, and make SoftwarePurpose entry description consistent - #885

Merged
zvr merged 1 commit into
spdx:mainfrom
bact:fix-typo-buildType
Sep 22, 2024
Merged

Fix typos, casing, and make SoftwarePurpose entry description consistent#885
zvr merged 1 commit into
spdx:mainfrom
bact:fix-typo-buildType

Conversation

@bact

@bact bact commented Sep 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Fix typos in model descriptions
  • Make sure that the property names have correct casing (starts with a lowercase letter) in model descriptions
    • "ExternalSpdxId identifies ..." --> "An externalSpdxId identifies ..."
  • Add "The" to entry description of SoftwarePurpose vocab (some already have, some don't; also make "The" casing consistent with entry description in other vocabs)
    • "Element ..." --> "The Element ..."

@bact
Fix typos and make entry desc format consistent
4f64ba7 
- Fix typos in model descriptions
- Make sure that the property names have correct casing (starts with a lowercase letter) in model descriptions
- Add "The" to entry description of SoftwarePurpose (some already have, some don't; also make "The" casing consistent with entry description in other vocabs)

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the documentation Improvements or additions to documentation label Sep 21, 2024
@bact
bact requested a review from sbarnum September 21, 2024 12:21
@bact bact mentioned this pull request Sep 21, 2024
Merged
goneall
goneall approved these changes Sep 21, 2024
View reviewed changes

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@zvr
zvr merged commit 935a120 into spdx:main Sep 22, 2024
@bact
bact deleted the fix-typo-buildType branch September 22, 2024 07:57
@bact bact added the typo Typos, minor spelling errors, or minor incorrect word usage label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zvr zvr zvr approved these changes
@goneall goneall goneall approved these changes
@sbarnum sbarnum Awaiting requested review from sbarnum

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation typo Typos, minor spelling errors, or minor incorrect word usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bact @zvr @goneall